From bb57d26eeef0fdf7367730cf629ee82e13d71c83 Mon Sep 17 00:00:00 2001 From: BloxerHD Date: Sat, 8 Aug 2026 16:08:26 +0100 Subject: [PATCH 1/2] feat(ci): Better Job Names --- .forgejo/workflows/build.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.forgejo/workflows/build.yml b/.forgejo/workflows/build.yml index 9341067..38f18a7 100644 --- a/.forgejo/workflows/build.yml +++ b/.forgejo/workflows/build.yml @@ -31,6 +31,8 @@ jobs: - edition: super-mario-maker db_secret: DATABASE_SMM - edition: terraria + + name: ${{ matrix.edition }} steps: - name: Checkout repository From 5389e75aa546507236aebb7c62be84adf709c996 Mon Sep 17 00:00:00 2001 From: BloxerHD Date: Sat, 8 Aug 2026 20:26:35 +0100 Subject: [PATCH 2/2] fix(ranking): Separate Splatoon specific methods --- Cargo.lock | 1 + rnex-protocols/rk-protos/src/ranking.rs | 2 ++ rnex-server-nex-modules/rnex-rk/Cargo.toml | 1 + rnex-server-nex-modules/rnex-rk/src/lib.rs | 22 ++++++++++++++++----- rnex-server-nex-modules/rnex-rk/src/user.rs | 2 ++ 5 files changed, 23 insertions(+), 5 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 5c37704..2240649 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2618,6 +2618,7 @@ dependencies = [ name = "rnex-rk" version = "0.1.0" dependencies = [ + "cfg-if", "rnex-rk-protos", "rnex-rmc", "rnex-server", diff --git a/rnex-protocols/rk-protos/src/ranking.rs b/rnex-protocols/rk-protos/src/ranking.rs index ed54d86..d9d2b57 100644 --- a/rnex-protocols/rk-protos/src/ranking.rs +++ b/rnex-protocols/rk-protos/src/ranking.rs @@ -59,11 +59,13 @@ pub struct CompetitionRankingScoreData { #[rmc_proto(112)] pub trait Ranking { #[method_id(16)] + #[cfg(feature = "splatoon")] async fn competition_ranking_get_param( &self, param: CompetitionRankingGetParam, ) -> Result, ErrorCode>; #[method_id(18)] + #[cfg(feature = "splatoon")] async fn upload_competition_ranking_score( &self, param: UploadCompetitionData, diff --git a/rnex-server-nex-modules/rnex-rk/Cargo.toml b/rnex-server-nex-modules/rnex-rk/Cargo.toml index dc1ee4a..542a6ef 100644 --- a/rnex-server-nex-modules/rnex-rk/Cargo.toml +++ b/rnex-server-nex-modules/rnex-rk/Cargo.toml @@ -22,6 +22,7 @@ datastore = ["database-support", "v3-8-15"] database-support = [] [dependencies] +cfg-if = "1.0.4" rnex-rmc = { path = "../../rnex-rmc" } rnex-util = { path = "../../rnex-util" } rnex-rk-protos = { path = "../../rnex-protocols/rk-protos" } diff --git a/rnex-server-nex-modules/rnex-rk/src/lib.rs b/rnex-server-nex-modules/rnex-rk/src/lib.rs index 0d872f9..546cffc 100644 --- a/rnex-server-nex-modules/rnex-rk/src/lib.rs +++ b/rnex-server-nex-modules/rnex-rk/src/lib.rs @@ -1,6 +1,7 @@ use rnex_rmc::response::ErrorCode; use rnex_server::{ConnectionInitData, EnvVarError, RnexManager, RnexModule, env_var}; use std::str::FromStr; +use cfg_if::cfg_if; use tracing::error; use crate::user::RankingUser; @@ -18,6 +19,7 @@ pub struct RankingModule; impl RankingManager { // Seperate function because I cannot give a fuck right now + #[cfg(feature = "splatoon")] async fn fetch_team_votes(&self, fest_id: u32) -> Result, ErrorCode> { let url_votes = format!("{}?splatfest_id={}", self.rnex_result_votes_get, fest_id); let Ok(response) = tokio::task::spawn_blocking(move || { @@ -76,10 +78,20 @@ impl RnexModule for RankingModule { async fn create_manager( _: &rnex_server::ModuleHolder, ) -> Result { - Ok(RankingManager { - rnex_result_votes_get: env_var("RNEX_SPLATOON_RESULTS_VOTES_GET")?, - rnex_result_post: env_var("RNEX_SPLATOON_RESULTS_POST")?, - rnex_result_get: env_var("RNEX_SPLATOON_RESULTS_GET")?, - }) + cfg_if!{ + if #[cfg(feature = "splatoon")] { + Ok(RankingManager { + rnex_result_votes_get: env_var("RNEX_SPLATOON_RESULTS_VOTES_GET")?, + rnex_result_post: env_var("RNEX_SPLATOON_RESULTS_POST")?, + rnex_result_get: env_var("RNEX_SPLATOON_RESULTS_GET")?, + }) + } else { + Ok(RankingManager { + rnex_result_get: "".into(), + rnex_result_post: "".into(), + rnex_result_votes_get: "".into(), + }) + } + } } } diff --git a/rnex-server-nex-modules/rnex-rk/src/user.rs b/rnex-server-nex-modules/rnex-rk/src/user.rs index 592c27f..d421a4c 100644 --- a/rnex-server-nex-modules/rnex-rk/src/user.rs +++ b/rnex-server-nex-modules/rnex-rk/src/user.rs @@ -30,6 +30,7 @@ pub struct CompetitionPostResults { } impl Ranking for RankingUser { + #[cfg(feature = "splatoon")] async fn competition_ranking_get_param( &self, param: CompetitionRankingGetParam, @@ -93,6 +94,7 @@ impl Ranking for RankingUser { Ok(vec![info]) } + #[cfg(feature = "splatoon")] async fn upload_competition_ranking_score( &self, param: UploadCompetitionData,