spacebar/malamar
Watch
14
0
Fork
You've already forked malamar
 0
forked from PretendoNetwork/Inkay
Code Pull requests Releases 1 Activity Actions

fix(config): Switch to snprintf for formatting

Browse source 
while vformat is closer to modern string-formatting sensibilities, it added 400KiB to our binaries, whereas snprintf has no noticeable impact. so... suffer, and hope the translators know what's up
This commit is contained in:
Ash Logan 2024-11-22 11:44:20 +11:00
commit cd1d530da9
2 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
plugin/src/config.cpp
View file

@ -140,8 +140,9 @@ static WUPSConfigAPICallbackStatus ConfigMenuOpenedCallback(WUPSConfigCategoryHa
{
uint16_t port = get_console_peertopeer_port();
std::string multiplayer_port_text = std::vformat(strings.multiplayer_port_display, std::make_format_args(port));
res = network_cat->add(WUPSConfigItemStub::Create(multiplayer_port_text), err);
char buffer[256];
snprintf(buffer, sizeof(buffer), strings.multiplayer_port_display.data(), port);
res = network_cat->add(WUPSConfigItemStub::Create(buffer), err);
if (!res) return report_error(err);
}