spacebar/malamar
Watch
14
0
Fork
You've already forked malamar
 0
forked from PretendoNetwork/Inkay
Code Pull requests Releases 1 Activity Actions

fix(config): Switch to snprintf for formatting

Browse source 
while vformat is closer to modern string-formatting sensibilities, it added 400KiB to our binaries, whereas snprintf has no noticeable impact. so... suffer, and hope the translators know what's up
This commit is contained in:
Ash Logan 2024-11-22 11:44:20 +11:00
commit cd1d530da9
2 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
plugin/src/config.cpp
View file

@ -140,8 +140,9 @@ static WUPSConfigAPICallbackStatus ConfigMenuOpenedCallback(WUPSConfigCategoryHa
{ {
uint16_t port = get_console_peertopeer_port(); uint16_t port = get_console_peertopeer_port();
std::string multiplayer_port_text = std::vformat(strings.multiplayer_port_display, std::make_format_args(port)); char buffer[256];
res = network_cat->add(WUPSConfigItemStub::Create(multiplayer_port_text), err); snprintf(buffer, sizeof(buffer), strings.multiplayer_port_display.data(), port);
res = network_cat->add(WUPSConfigItemStub::Create(buffer), err);
if (!res) return report_error(err); if (!res) return report_error(err);
} }

2
src/lang/en_US.lang
View file

@ -8,6 +8,6 @@
,.need_menu_action = "From WiiU menu only" ,.need_menu_action = "From WiiU menu only"
,.using_nintendo_network = "Using Nintendo Network" ,.using_nintendo_network = "Using Nintendo Network"
,.using_pretendo_network = "Using Pretendo Network" ,.using_pretendo_network = "Using Pretendo Network"
,.multiplayer_port_display = "Using UDP port {} for multiplayer" ,.multiplayer_port_display = "Using UDP port %hu for multiplayer"
,.module_not_found = "Pretendo patch failed - use Aroma Updater to repair (686-1001 Module missing)" ,.module_not_found = "Pretendo patch failed - use Aroma Updater to repair (686-1001 Module missing)"
,.module_init_not_found = "Pretendo patch failed - use Aroma Updater to repair (686-1002 Module init)" ,.module_init_not_found = "Pretendo patch failed - use Aroma Updater to repair (686-1002 Module init)"