fix warnings and criterion in main

rnex-core/src/rmc/response.rs

@@ -471,7 +471,7 @@ mod test {
 
     #[test]
     fn test() {
-        let mut data_orig = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 69, 4, 20];
+        let data_orig = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 69, 4, 20];
         let mut data = data_orig;
 
         let mut rc4: Rc4<U5> =

rnex-core/src/rmc/structures/any.rs

@@ -21,7 +21,7 @@ impl RmcSerialize for Any{
 
         Ok(())
     }
-    fn deserialize(mut reader: &mut impl Read) -> Result<Self> {
+    fn deserialize(reader: &mut impl Read) -> Result<Self> {
         let name = String::deserialize(reader)?;
 
         // also length ?

rnex-core/src/rmc/structures/list.rs

@@ -20,7 +20,7 @@ impl<T: RmcSerialize> RmcSerialize for Vec<T>{
         Ok(())
     }
 
-    fn deserialize(mut reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
+    fn deserialize(reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
         let len: u32 = reader.read_struct(IS_BIG_ENDIAN)?;
 
         //let mut vec = Vec::with_capacity(len as usize);

rnex-core/src/rmc/structures/primitives.rs

@@ -10,7 +10,7 @@ impl RmcSerialize for u8{
     }
 
     #[inline(always)]
-    fn deserialize(mut reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
+    fn deserialize(reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
         Ok(reader.read_struct(IS_BIG_ENDIAN)?)
     }
     #[inline(always)]
@@ -26,7 +26,7 @@ impl RmcSerialize for i8{
     }
 
     #[inline(always)]
-    fn deserialize(mut reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
+    fn deserialize(reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
         Ok(reader.read_struct(IS_BIG_ENDIAN)?)
     }
     #[inline(always)]
@@ -41,7 +41,7 @@ impl RmcSerialize for u16{
         Ok(writer.write_all(bytes_of(self))?)
     }
     #[inline(always)]
-    fn deserialize(mut reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
+    fn deserialize(reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
         Ok(reader.read_struct(IS_BIG_ENDIAN)?)
     }
     #[inline(always)]
@@ -56,7 +56,7 @@ impl RmcSerialize for i16{
         Ok(writer.write_all(bytes_of(self))?)
     }
     #[inline(always)]
-    fn deserialize(mut reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
+    fn deserialize(reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
         Ok(reader.read_struct(IS_BIG_ENDIAN)?)
     }
     #[inline(always)]
@@ -71,7 +71,7 @@ impl RmcSerialize for u32{
         Ok(writer.write_all(bytes_of(self))?)
     }
     #[inline(always)]
-    fn deserialize(mut reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
+    fn deserialize(reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
         Ok(reader.read_struct(IS_BIG_ENDIAN)?)
     }
     #[inline(always)]
@@ -86,7 +86,7 @@ impl RmcSerialize for i32{
         Ok(writer.write_all(bytes_of(self))?)
     }
     #[inline(always)]
-    fn deserialize(mut reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
+    fn deserialize(reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
         Ok(reader.read_struct(IS_BIG_ENDIAN)?)
     }
     #[inline(always)]
@@ -101,7 +101,7 @@ impl RmcSerialize for u64{
         Ok(writer.write_all(bytes_of(self))?)
     }
     #[inline(always)]
-    fn deserialize(mut reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
+    fn deserialize(reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
         Ok(reader.read_struct(IS_BIG_ENDIAN)?)
     }
     #[inline(always)]
@@ -116,7 +116,7 @@ impl RmcSerialize for i64{
         Ok(writer.write_all(bytes_of(self))?)
     }
     #[inline(always)]
-    fn deserialize(mut reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
+    fn deserialize(reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
         Ok(reader.read_struct(IS_BIG_ENDIAN)?)
     }
     #[inline(always)]
@@ -132,7 +132,7 @@ impl RmcSerialize for f64{
     }
 
     #[inline(always)]
-    fn deserialize(mut reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
+    fn deserialize(reader: &mut impl Read) -> crate::rmc::structures::Result<Self> {
         Ok(reader.read_struct(IS_BIG_ENDIAN)?)
     }
     #[inline(always)]

rnex-core/src/rmc/structures/qbuffer.rs

@@ -17,7 +17,7 @@ impl RmcSerialize for QBuffer{
         Ok(())
     }
 
-    fn deserialize(mut reader: &mut impl Read) -> Result<Self> {
+    fn deserialize(reader: &mut impl Read) -> Result<Self> {
         let size: u16 = reader.read_struct(IS_BIG_ENDIAN)?;
 
         let mut vec = vec![0; size as usize];

rnex-core/src/rmc/structures/qresult.rs

@@ -31,7 +31,7 @@ impl RmcSerialize for QResult{
         Ok(())
     }
 
-    fn deserialize(mut reader: &mut impl Read) -> Result<Self> {
+    fn deserialize(reader: &mut impl Read) -> Result<Self> {
         Ok(reader.read_struct(IS_BIG_ENDIAN)?)
     }
 }

rnex-core/src/rmc/structures/ranking.rs

@@ -25,7 +25,6 @@ struct UserData{
 mod test{
     use std::io::Cursor;
     use bytemuck::from_bytes;
-    use tokio::io::AsyncReadExt;
     use crate::rmc::structures::ranking::{UploadCompetitionData, UserData};
     use rnex_core::rmc::structures::RmcSerialize;
 

rnex-core/src/rmc/structures/rmc_struct.rs

@@ -1,15 +1,11 @@
-use std::any::Any;
+
 use std::cmp::max;
 use std::fmt::Arguments;
 use std::io;
-use std::io::{Cursor, ErrorKind, IoSlice, Read, Write};
-use std::ops::Sub;
-use bytemuck::bytes_of;
-use v_byte_helpers::{IS_BIG_ENDIAN, ReadExtensions};
-use crate::rmc::structures;
-use crate::rmc::structures::Error::VersionMismatch;
+use std::io::{ErrorKind, IoSlice, Read, Write};
 use crate::rmc::structures::Result;
 
+
 #[repr(C, packed)]
 struct StructureHeader{
     version: u8,
@@ -43,6 +39,8 @@ impl Write for OnlyWriteVec<'_> {
 
 #[cfg(feature = "rmc_struct_header")]
 pub fn write_struct<T: Write>(writer: &mut T, version: u8, inner_size: u32, pred: impl FnOnce(&mut T) -> Result<()> ) -> Result<()> {
+    use bytemuck::bytes_of;
+
     writer.write_all(&[version])?;
 
     writer.write_all(bytes_of(&inner_size))?;
@@ -55,7 +53,7 @@ pub fn write_struct<T: Write>(writer: &mut T, version: u8, inner_size: u32, pred
 
 
 #[cfg(not(feature = "rmc_struct_header"))]
-pub fn write_struct<T: Write>(writer: &mut T, version: u8, _inner_size: u32, pred: impl FnOnce(&mut T) -> Result<()> ) -> Result<()> {
+pub fn write_struct<T: Write>(writer: &mut T, _version: u8, _inner_size: u32, pred: impl FnOnce(&mut T) -> Result<()> ) -> Result<()> {
     pred(writer)
 }
 
@@ -94,7 +92,10 @@ impl<T: Read> Read for SubRead<'_, T>{
 }
 
 #[cfg(feature = "rmc_struct_header")]
-pub fn read_struct<T: Sized, R: Read>(mut reader: &mut R, version: u8, pred: impl FnOnce(&mut SubRead<R>) -> Result<T>) -> Result<T> {
+pub fn read_struct<T: Sized, R: Read>(reader: &mut R, version: u8, pred: impl FnOnce(&mut SubRead<R>) -> Result<T>) -> Result<T> {
+    use crate::rmc::structures::Error::VersionMismatch;
+    use v_byte_helpers::ReadExtensions;
+    use v_byte_helpers::IS_BIG_ENDIAN;
     let ver: u8 = reader.read_struct(IS_BIG_ENDIAN)?;
 
     if ver != version {
@@ -107,6 +108,6 @@ pub fn read_struct<T: Sized, R: Read>(mut reader: &mut R, version: u8, pred: imp
 }
 
 #[cfg(not(feature = "rmc_struct_header"))]
-pub fn read_struct<T: Sized, R: Read>(mut reader: &mut R, version: u8, pred: impl FnOnce(&mut R) -> Result<T>) -> Result<T> {
+pub fn read_struct<T: Sized, R: Read>(mut reader: &mut R, _version: u8, pred: impl FnOnce(&mut R) -> Result<T>) -> Result<T> {
     Ok(pred(&mut reader)?)
 }

rnex-core/src/rmc/structures/string.rs

@@ -5,7 +5,7 @@ use v_byte_helpers::{IS_BIG_ENDIAN, ReadExtensions};
 use super::{Result, RmcSerialize};
 
 impl RmcSerialize for String{
-    fn deserialize(mut reader: &mut impl Read) -> Result<Self> {
+    fn deserialize(reader: &mut impl Read) -> Result<Self> {
         let len: u16 = reader.read_struct(IS_BIG_ENDIAN)?;
         if len == 0{
             return Ok("".to_string());