clean up a bit and fix scripts

build-edition.sh

@@ -1,4 +1,7 @@
 #!/usr/bin/env bash
+
+set -euo pipefail
+
 if [ -z ${EDITION+x} ]; then
     EDITION=$1
 fi

buildscripts/common.sh

@@ -1,5 +1,7 @@
 #!/usr/bin/env bash
-set -e pipefail
+
+set -euo pipefail
+
 TMP_FEATURES_TRAILINGCOMMA=$(yq ea ".$EDITION.features" editions.yaml  | sed 's/- //g' | tr '\n' ',')
 export EDITION_FEATURES=${TMP_FEATURES_TRAILINGCOMMA::-1}
 SETTINGS=$(yq ea ".$EDITION.settings" editions.yaml | yq 'keys[]')

check-all.sh

@@ -1,9 +1,10 @@
 #!/usr/bin/env bash
 
-set -e pipefail
+set -euo pipefail
 
 SETTINGS=$(yq ea "." editions.yaml | yq 'keys[]')
 IFS=$'\n'
 while IFS=$'\n' read -r EDITION; do
+    export EDITION
     ./check-edition.sh $EDITION
 done <<< "$SETTINGS"

check-edition.sh

@@ -1,9 +1,10 @@
 #!/usr/bin/env bash
 
-set -e pipefail
+
+set -euo pipefail
 
 if [ -z ${EDITION+x} ]; then
-    EDITION=$1
+    export EDITION=$1
 fi
 
 # comma seperated list of features for the specified version

rnex-core/src/util.rs

@@ -1,9 +1,8 @@
 use crate::reggie::{UnitPacketRead, UnitPacketWrite};
 use log::{error, info};
-use std::iter::FilterMap;
 use std::ops::Deref;
 use std::sync::{Arc, Weak};
-use std::{slice, vec};
+use std::vec;
 use tokio::io::{AsyncRead, AsyncWrite, AsyncWriteExt};
 use tokio::sync::Notify;
 use tokio::sync::mpsc::{Receiver, Sender, channel};

test-edition.sh

@@ -1,4 +1,7 @@
 #!/usr/bin/env bash
+
+set -euo pipefail
+
 if [ -z ${EDITION+x} ]; then
     EDITION=$1
 fi