spacebar/account
6
0
Fork 0
Code Issues 1 Pull requests 7 Projects Releases Packages 1 Wiki Activity Actions

Implement /v1/api/miis?pids= #5

Merged
redbinder0526 merged 6 commits from main into main 2026-04-12 15:53:43 +02:00
Conversation 12 Commits 6 Files changed 3 +122
redbinder0526 commented 2026-04-12 15:06:35 +02:00 (Migrated from git.virintox.com)
Copy link

This PR adds the route to fetch mii data, which also includes SFID data.

This PR adds the route to fetch mii data, which also includes SFID data.
redbinder0526 commented 2026-04-12 15:18:48 +02:00 (Migrated from git.virintox.com)
Copy link

added 1 commit

  • 2bfb3790 - Correctly use the mii server env variable

Compare with previous version

added 1 commit <ul><li>2bfb3790 - Correctly use the mii server env variable</li></ul> [Compare with previous version](/spfn/account/-/merge_requests/5/diffs?diff_id=52&start_sha=a281b56cc839f180a7bd8b92a9e367a72549680e)
RusticMaple commented 2026-04-12 15:19:28 +02:00 (Migrated from git.virintox.com)
Copy link

this is incorrect usage of the get_mii_img_url function, how it works is that the first parameter is the pid and the second one is the image you want to grab from that user, how you are using it will not work

this is incorrect usage of the get_mii_img_url function, how it works is that the first parameter is the pid and the second one is the image you want to grab from that user, how you are using it will not work
RusticMaple commented 2026-04-12 15:19:28 +02:00 (Migrated from git.virintox.com)
Copy link

requested changes

requested changes
RusticMaple commented 2026-04-12 15:25:16 +02:00 (Migrated from git.virintox.com)
Copy link

this is not how the mii caching server functions, please check with mii_util.rs

this is not how the mii caching server functions, please check with `mii_util.rs`
RusticMaple commented 2026-04-12 15:25:16 +02:00 (Migrated from git.virintox.com)
Copy link

requested changes

requested changes
redbinder0526 commented 2026-04-12 15:27:31 +02:00 (Migrated from git.virintox.com)
Copy link

you literally named the second parameter "format"

you literally named the second parameter "format"
redbinder0526 commented 2026-04-12 15:36:10 +02:00 (Migrated from git.virintox.com)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/spfn/account/-/merge_requests/5/diffs?diff_id=54&start_sha=2bfb3790df5ea252d1b28d0b7af55a2542c45821#a0df072f87b2dd6a69bbbd1deeb7b20d376c2ddd_95_95)
redbinder0526 commented 2026-04-12 15:36:11 +02:00 (Migrated from git.virintox.com)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>71c23ff2 - Correctly use caching server</li></ul> [Compare with previous version](/spfn/account/-/merge_requests/5/diffs?diff_id=54&start_sha=2bfb3790df5ea252d1b28d0b7af55a2542c45821)
redbinder0526 commented 2026-04-12 15:36:19 +02:00 (Migrated from git.virintox.com)
Copy link

fixed in 71c23ff

fixed in 71c23ff
redbinder0526 commented 2026-04-12 15:36:19 +02:00 (Migrated from git.virintox.com)
Copy link

resolved all threads

resolved all threads
RusticMaple commented 2026-04-12 15:53:38 +02:00 (Migrated from git.virintox.com)
Copy link

lgtm

lgtm
RusticMaple commented 2026-04-12 15:53:43 +02:00 (Migrated from git.virintox.com)
Copy link

mentioned in commit 144728efd2

mentioned in commit 144728efd22c70f44c4eef18c7cd0c1cee1778fd
RusticMaple (Migrated from git.virintox.com) merged commit 144728efd2 into main 2026-04-12 15:53:43 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
spacebar/account!5
No description provided.